JassHelper 0.A.2.B - A vJass and Zinc 2 Jass compiler

[Vexorian]

If I remember it is the factory that has the bug, and not jasshelper.

So maybe if you told me what the error actually says instead of just the line, it would help.

[Vexorian]

Originally Posted by C2H3NaO2

No it does not work without public, but if it extends something (struct or interface) it works without problems.

For now you can add a dummy private struct to fix it:

JASS:

struct st1
    public stub method asdf takes nothing returns nothing
    endmethod
endstruct

private struct dummy extends st1
endstruct

[gekko]

Originally Posted by gekko

is there a way to use getType() for arrays that are not extended from an interface? I have some structs extended from other structs and I would like to determine which child type a variable of the super struct type is.

Or can I just make a "dummy" superinterace with no content for the superstruct just to add this functionality. Or will I suffer other inconvenience (especially regarding performance) if I use a super interface?

Oh and I have found a bug:
You cannot give structs methods names that also a normal function already has . You get the error "1 is not a member of <THE_STRUCTTYPE>". I hope this is not intended, as there are many cases where I want a global function with the same name than a method of a struct, and it should be no problem to distinguish them, since they use different namespaces. I can also have globals and struct member variables with the same names, but no functions :(.

Next issue:

May it be that this "private keyword xxx" stuff totally malfunctions if used inside a library instead of a scope. Could you please fix this? I don't want to create a surrounding scope in my library just to add that private keyword stuff.
Because this adds a new problem: How to make a private init function in such a construct? I cannot make a scope init function, so i have to declare it as initializer for the library surrounding it. However, if I put a scope inside the library and make the init function private, the library header cannot see it as it is private to the scope, that is REALLY nasty and forces me to make many members public that i would need private in one library. It wastes all my encapsulation efforts :(.

Hey Vex. You seem to have skipped my post by accident(or ignored?). Could you please give some feedback?

[Vexorian]

Or can I just make a "dummy" superinterace with no content

Sure, though getType should be trivial to make work in structs, I think there is just a check requiring interfaces for some odd reason.

You cannot give structs methods names that also a normal function already has . You get the error "1 is not a member of <THE_STRUCTTYPE>". I hope this is not intended, as there are many cases where I want a global function with the same name than a method of a struct, and it should be no problem to distinguish them, since they use different namespaces. I can also have globals and struct member variables with the same names, but no functions :(.

This is related to scopes, if the function is in the same scope it will happen, that's a good thing because at least you have control of what goes in your scope so you can work around it, cause it seems unlikely this will get fixed too soon.

May it be that this "private keyword xxx" stuff totally malfunctions if used inside a library instead of a scope. Could you please fix this?

For that sort of thing libraries and scopes are exactly the same thing, so I just don't think this is true, you'll have to give actual examples.


Edit: I just fixed that bug with stub methods on a final struct causing PJass errors and also made getType() callable on any struct instance, if anyone has a quick bug report to make, better do it in the next few hours before I make the new release...

[Vexorian]

all right, F.4

[gekko]

Originally Posted by Vexorian

all right, F.4
The getType() method can be called on any struct instance (not just interface variables)

Yay, big thanks :).
I will find a codeexample for my private keyword issue.

concerning function/method with same name:

I am totally sure that the function and the struct method were in different scopes. They were in different libraries, to be precise. But I cannot reconstruct that bug at the moment it works, strange.

Next issue:
I need something that is private but can be shared between two libraries. I really don't want to merge them to one, because they re really big and do different things and I like to have them in two different triggers, but they share some private content. How could this be done?

[ShadowDestroyer]

I don't think it is spell factory...

The error is simply "Syntax Error", with no other information.

[Av3n]

Ok Vexorian I think the new JASSHelper cannot handle more than 23188 lines anymore, I get this error right before "JASSHelper - Structs Writing" finishes:

Access violation at address 00480E08 in module 'jasshelper.exe'. Read of address 00000016.

This is with your latest one F.4. Or it just might be my Vista failing at life, since it works on smaller ones.

-Av3n

[Vexorian]

I doubt it is related to large files.

the bad news is that you'll probably have to disable triggers one by one until you find what's causing thing.

edit: ...or you can send me your inputwar3map.j

[ShadowDestroyer]

Hey Vex,

The Spell Factory returns:
function SlashTemplate_DoSpell takes player ow, unit t, integer s, integer l returns nothing

and the only information it gives is "Syntax Error".

Would you mind helping me out?

[TriggerHappy]

Whats the line above/under that line.

[Av3n]

a.k.a, post the whole damn code, people cannot solve problems with with jsut one line of code, even if it is the creator of the system.

I'll PM the inputwar3map.j

-Av3n

[Troll-Brain]

A suggestion.
Could you create an other thing :

Block <optional name> / endblock : Just a code block, we can't use private or public, and we can use the same name several times if we want.

What's the point of that ?
Hide/unhide hudge block codes to keep the readability of the code, an alternative of nested scopes.

[Vexorian]

Hiding? Is that editor-related ? Reminds me of C#'s regions. Hmnn.

[Troll-Brain]

I mean minimize / show the block like that :

Block minimized:

// code

Block not minimized:

// code

Ofc, TESH must also be edited as well, but it would be very easy and fast to add this.