JassHelper 0.A.2.B - A vJass and Zinc 2 Jass compiler

[cohadar]

Originally Posted by Vexorian

If I had to choose between just using .release and having to open that XP virtual machine to add stuff to jasshelper, I would stick to release, it is actually cute.

You are unable to modify jasshelper now? wtf...

[Vexorian]

I've been using the VM to code jasshelper for a long time, but I've been feeling unmotivated to do that stuff, maybe after the hero contest.

[Themis]

I might have an idea that might optimize the jass code a lot, and shouldn't be a lot of work.

JASS:

function example takes real x y facing, unit u returns nothing

Converts to:

JASS:

function example takes real x, real y, real facing, unit u returns nothing

As in many languages you don't have to re-declare the type of variable, but separate it with a comma. However due to free type declaration it should be easier to detect when a comma isn't used.

[Vexorian]

Just like you'd make an array of any other type.

JASS:

globals
     mystruct array A
endglobals

[Zerzax]

This might be a bug in the compiler: I declared an array within a struct with a limit of 3, and use indices 1, 2, and 3 in the script. I get a syntax error claiming that 3 is an array index out of bounds, while I can use a loop and never directly reference index 3 and JassHelper has no problems with that.

[Vexorian]

Size 3: Use indexes 0,1,2

Programming is often 0-based.

[Zerzax]

I forgot to mention that this array is of another struct type. I was under the impression that I should avoid using index 0 in struct arrays because I've had MUI and double free issues when doing so. Doesn't mean I'm right, but...

EDIT: Does this mean I've been going out of array bounds when using the "limiting" index of an array (3 for example, in a loop)?

[Pyrogasm]

Originally Posted by Zerzax

I forgot to mention that this array is of another struct type. I was under the impression that I should avoid using index 0 in struct arrays because I've had MUI and double free issues when doing so. Doesn't mean I'm right, but..

If you have this:

JASS:

globals
    keyword MyStruct
    MyStruct array MyStructs
endglobals

struct MyStruct
    integer Blah
endstruct

Then MyStruct(0) is different from MyStructs[0] because one is an array lookup (no problems there) and one is direct access to an instance of the struct, and 0 is, unless I'm mistaken. never used as a struct instance.

Originally Posted by Zerzax

EDIT: Does this mean I've been going out of array bounds when using the "limiting" index of an array (3 for example, in a loop)?

If you mean you're doing this, then yes:

JASS:

struct Blah
    integer  array Stuff[3]
endstruct

function Garrr takes nothing returns nothing
    local Blah B = Blah.create()
    local integer J = 0

    loop
       set J = J+1
       exitwhen J > 3
       set Blah.Stuff[J] = GetRandomInt(0, 10)
    endloop
endfunction

[Zerzax]

Good thing I raised the point, that would hurt my Hero Contest judging if I ever got there.

I was doing this:

JASS:

struct flaremissile 
endstruct

struct caster
    flaremissile array castMissiles[3]

    method Garrrr takes nothing returns nothing
        local integer i = 1
        local flaremissile f 
        
        loop
            exitwhen i > 3
            set f = this.castmissiles[i]
            // actions...
            set i = i + 1
        endloop
    endmethod
endstruct

I wasn't really being specific enough when I said struct arrays. I believe when you use the 0 index in this case, it is exactly as you described Pyro (never used as a struct instance).

[Vexorian]

I was under the impression that I should avoid using index 0 in struct arrays because I've had MUI and double free issues when doing so. Doesn't mean I'm right, but...

Perhaps you were using index N on arrays of size N and that caused your issues with index zero.

EDIT: Does this mean I've been going out of array bounds when using the "limiting" index of an array (3 for example, in a loop)?

Yes.

[Zerzax]

I'll start using indices 0 to Limit - 1 instead now. Thanks to both of you :D.