Feedback on Prism Tower

[Hans_Maulwurf]

So I was trying to trigger the c&c red alert 2 prism tower (which can charge nearby allied towers up).


Looks quite complicated at first, however it turned out to a simple code.

JASS:

//---------------------
// Configuration
//---------------------
    //! runtextmacro AddUnitsWithAbility("A000", "500", "10*(level+1)", "2")
//---------------------
// End of Configuration
//---------------------

//! textmacro AddUnitsWithAbility takes TYPE, RANGE, DAMAGE, COOLDOWN
scope Lightningtower$TYPE$ initializer Init

globals
    private group attacked
    private real damage
    private player owner
    private integer attacks
    private group inrange
    private group current
    private timer gametime
endglobals

private function Filter takes nothing returns boolean
    return ( not IsUnitInGroup(GetFilterUnit(), attacked) ) and GetOwningPlayer(GetFilterUnit()) == owner and GetUnitUserData(GetFilterUnit()) < TimerGetElapsed(gametime)*100 and GetUnitAbilityLevel(GetFilterUnit(), '$TYPE$') > 0
endfunction

private function Actions$TYPE$ takes nothing returns nothing
    local unit attacker = GetAttacker()
    local unit target = GetTriggerUnit()
    local real x1 = GetUnitX(attacker)
    local real y1 = GetUnitY(attacker)
    local real x2 = GetUnitX(target)
    local real y2 = GetUnitY(target)
    local unit c
    local integer level

    call GroupClear(attacked)
    call GroupClear(current)
    call GroupClear(inrange)
    set damage = 0
    set owner = GetOwningPlayer(attacker)
    
    call GroupAddUnit(attacked, attacker)
    call AddLightningEx( "FORK", true, x1, y1, 200, x2, y2, 0 ) //TODO: write or find a timed lightning lib
    
    set level = GetUnitAbilityLevel(attacker, '$TYPE$')
    set damage = $DAMAGE$ //declare "level" before using this
    
    call SetUnitUserData( attacker, R2I( (TimerGetElapsed(gametime)+($COOLDOWN$) )*100) ) //same here
    
    call GroupEnumUnitsInRange(inrange, x1, y1, $RANGE$, Condition( function Filter ))
    
    loop
        set c = FirstOfGroup(inrange)
        
        if (c == null) then
            set attacker = FirstOfGroup(current)
            call GroupRemoveUnit(current, attacker)
            set x1 = GetUnitX(attacker)
            set y1 = GetUnitY(attacker)
            call GroupEnumUnitsInRange(inrange, x1, y1, $RANGE$, Condition( function Filter ))
            set c = FirstOfGroup(inrange)
        endif
        
        exitwhen c == null

        set x2 = GetUnitX(c)
        set y2 = GetUnitY(c)
        
        call GroupAddUnit(attacked, c)
        call AddLightningEx( "FORK", true, x1, y1, 200, x2, y2, 200 ) //TODO: write or find a timed lightning lib
        
        set level = GetUnitAbilityLevel(c, '$TYPE$')
        set damage = damage + ($DAMAGE$) //declare "level" before using this
        
        call SetUnitUserData( c, R2I( (TimerGetElapsed(gametime)+($COOLDOWN$) )*100) ) //same here

        call GroupRemoveUnit(inrange, c)
        call GroupAddUnit(current, c)
    endloop
    
    call BJDebugMsg(R2S(damage)+" Damage") //TODO: actually deal the damage
    
    set attacker = null
    set target = null
endfunction

private function IsUnitType$TYPE$ takes nothing returns boolean
    return GetUnitAbilityLevel(GetAttacker(), '$TYPE$') > 0 and GetUnitUserData(GetAttacker()) < TimerGetElapsed(gametime)*100 and ( not IsUnitInGroup(GetAttacker(), attacked) )
endfunction

private function AddUnitsWithAbility$TYPE$ takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED)
    call TriggerAddCondition(t, Condition( function IsUnitType$TYPE$ ))
    call TriggerAddAction(t, function Actions$TYPE$)
    set t = null
endfunction
 
private function Init takes nothing returns nothing
    call AddUnitsWithAbility$TYPE$()
    set attacked = CreateGroup()
    set inrange = CreateGroup()
    set current = CreateGroup()
    set gametime = CreateTimer()
    call TimerStart(gametime, 36000000, false, null)
endfunction 

endscope
//! endtextmacro

You will propably notice that textmacro stuff at first. The reason I made this, instead of the default static functions and globals configuration is, this way I can make different towers charge each other up (by using different levels of the ability for each towertype) but still make different kinds of lightning which won´t charge up the others by simply adding another runtextmacro line. Hope you got what I wanted to say, lol. my english isn´t the best. also this was the first what came to mind. maybe i´ll figure out something better for that problem.

And don´t focus on the UserData, i use to set and get each towers cooldown. I´ll replace it later by some gamechache/UnitIndex/whatever method.

I marked the important lines (the loop) and attached my testmap, which seems to work perfectly

Please post your ideas on how to improve this :)

[0zyx0]

It shouldn't display the damage as a real value. The decimal part is not necessary at all.

[Bobo_The_Kodo]

It shouldn't display the damage as a real value. The decimal part is not necessary at all.

Failllllllllll

[Alevice]

The text macro configuration is quite interesting. Im really curious about this script, will surely give it a try later today :)

[Kyrbi0]

I love you.

Is this made to be easily copy/pasteable? And is that a custom lightning.slk I spy?

[Alevice]

Originally Posted by Kyrbi0

I love you.

Is this made to be easily copy/pasteable? And is that a custom lightning.slk I spy?

It is with newgen. And the lignting seems to be forked lightning. :P

[Kyrbi0]

Originally Posted by Alevice

It is with newgen.

GAAAH!!!

Originally Posted by Alevice

And the lignting seems to be forked lightning. :P

Really? I was just taking a guess, as the screenshot seemed to freeze the lightning in a very cool-looking pose (one which I didn't recognize from in-game).

[Alevice]

Originally Posted by Kyrbi0

GAAAH!!!

I thought you got it to wrok already? Why so reluctant? Newgen wont eat your children. Okay, maybe it well, but hey, it will be worth it.

[Hans_Maulwurf]

Originally Posted by Kyrbi0

I love you.

Is this made to be easily copy/pasteable? And is that a custom lightning.slk I spy?

as it is at the moment, you only have to copy the trigger and change the first line:

//! runtextmacro AddUnitsWithAbility("A000", "500", "10*(level+1)", "2")
A000 is the ability a unit has to have, to do this
500 is the range
10*(level+1) is the damage per tower
2 is the cooldown

You need vJass (New Gen WE) to save it.

And it uses "FORK" (forked lightning).

However its not done yet

[Kyrbi0]

Oh... So I could just open Newgen WE, open my (whatever) map, insert the code (make the aforementioned changes), and save it. After that, I could open/modify/save it in regular WE, or play it in regular WE?

[Alevice]

You can open it on regular wc3 once saved, but you cant get it to work on regular we.

[Kwah]

Pitzy ate my babies.

But on a serious note, it's kinda sexy.

EDIT: That is the lightning, not Pitzy eating.

[Anopob]

Originally Posted by Kyrbi0

Oh... So I could just open Newgen WE, open my (whatever) map, insert the code (make the aforementioned changes), and save it. After that, I could open/modify/save it in regular WE, or play it in regular WE?

No. I guess he meant saving as in saving, compiling and editing.

Is the lightning shown there the main lightning from forked lightning? I mean it doesn't look like it but I guess it's so fast I hardly notice it's purple. That looks awesome though.

[fX_]

looks interesting + ss is 'oooooooooooo'

edit: i'd use a tinted drain lightning model for the beam coz it shows particles moving.

[Pyrogasm]

Kyrbi0, if you're so resistant to using the normal WE, do you want me to teach you my setup so you can import relevant jass scripts and still use the Vanilla WE whenever necessary?