wc3campaigns
WC3C Homepage - www.wc3c.netUser Control Panel (Requires Log-In)Engage in discussions with other users and join contests in the WC3C forums!Read one of our many tutorials, ranging in difficulty from beginner to advanced!Show off your artistic talents in the WC3C Gallery!Download quality models, textures, spells (vJASS/JASS), systems, and scripts!Download maps that have passed through our rigorous approval process!

Go Back   Wc3C.net > Resources > Code Resources > vJass Spells
User Name
Password
Register Rules Get Hosted! Chat Pastebin FAQ and Rules Members List Calendar



Reply
 
Thread Tools Search this Thread
Old 11-11-2007, 07:26 PM   #16
moyack
Evil Emoticon
 
moyack's Avatar


Respected User
Project Leader: PoC
 
Join Date: Jan 2006
Posts: 3,279

Submissions (17)

moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)

AI Tournament #2 - 2nd PlaceHero Contest - Second place

Send a message via MSN to moyack
Default

hellooo!!!! any update??
moyack is offline   Reply With Quote
Sponsored Links - Login to hide this ad!
Old 11-12-2007, 12:32 PM   #17
Fireeye
Chos
 
Fireeye's Avatar
 
Join Date: Jun 2006
Posts: 495

Submissions (2)

Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)

Default

The update is done, but if i understand the integer() somestruct() thing correct it's not needed in this case because i don't set an integer/struct equal to a struct/integer.
However i removed some lines of code and made the changes suggested by you.
Btw. thank you for kicking my ass again.
__________________

Last edited by Fireeye : 11-12-2007 at 12:32 PM.
Fireeye is offline   Reply With Quote
Old 11-28-2007, 12:14 AM   #18
moyack
Evil Emoticon
 
moyack's Avatar


Respected User
Project Leader: PoC
 
Join Date: Jan 2006
Posts: 3,279

Submissions (17)

moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)

AI Tournament #2 - 2nd PlaceHero Contest - Second place

Send a message via MSN to moyack
Default

Ok, I've checked your spell, and I liked how you solved the integer(Data) :)

Some minor things easy to solve:
  • You use in the tree detection a constant value which should be part of the constant globals, in this line:
    Collapse JASS:
    call SetRect(TreeRect,x2-96,y2-96,x2+96,y2+96) // make the values a constant global variable
  • You can make the spell structs private, at the end they shouldn't be accessible to other functions and we ensure they don't mess with other popular knockback structs in other maps.
  • You do this calculation:
    Collapse JASS:
    set twdat.speed = StartCircleSpeed*bj_PI/180.0
    set twdat.increament = DecreaseCircleSpeed (level)*bj_PI/180.0
    Collapse JASS:
    call SetUnitFacing(twdat.target,twdat.angle*(180/3.1415))
    call SetUnitFacing(twdat.caster,twdat.angle*(180/3.1415))

    You can replace bj_PI/180.0 by bj_DEGTORAD and 180/3.1415 by bj_RADTODEG

Please fix that and I'll approve this spell.
moyack is offline   Reply With Quote
Old 11-28-2007, 06:35 PM   #19
Fireeye
Chos
 
Fireeye's Avatar
 
Join Date: Jun 2006
Posts: 495

Submissions (2)

Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)Fireeye has a spectacular aura about (113)

Default

Alright, made all changes (hopefully), the first post is already edited.
__________________
Fireeye is offline   Reply With Quote
Old 11-29-2007, 12:02 AM   #20
moyack
Evil Emoticon
 
moyack's Avatar


Respected User
Project Leader: PoC
 
Join Date: Jan 2006
Posts: 3,279

Submissions (17)

moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)

AI Tournament #2 - 2nd PlaceHero Contest - Second place

Send a message via MSN to moyack
Default

Aprovezord.
moyack is offline   Reply With Quote
Old 11-29-2007, 12:35 AM   #21
cohadar
master of fugue
 
cohadar's Avatar
 
Join Date: Jun 2007
Posts: 2,453

Submissions (5)

cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)

Default

lol didn't know we still have mods who actually work around here.
__________________
Omg database crash deleted my signature, as a side effect this immensely improved wc3c.
cohadar is offline   Reply With Quote
Old 11-29-2007, 01:59 PM   #22
Rising_Dusk
Obscurity, the Art


Projects Director
Project Leader: OD
 
Join Date: Feb 2006
Posts: 9,729

Submissions (27)

Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)

Hero Contest #3 - 1st PlaceApproved Map: Desert of ExileApproved Map: Advent of the ZenithHero Contest #2 - 1st PlaceHero Contest - Third place>

Send a message via AIM to Rising_Dusk Send a message via MSN to Rising_Dusk
Default

Quote:
lol didn't know any mods here had the free time to go through and approve resources because they have real lives that clearly take precedence over WC3 shit
Fixed.
__________________
Rising_Dusk is offline   Reply With Quote
Old 11-29-2007, 02:34 PM   #23
cohadar
master of fugue
 
cohadar's Avatar
 
Join Date: Jun 2007
Posts: 2,453

Submissions (5)

cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)cohadar is just really nice (250)

Default

But somehow always find time for bullshit comments...
__________________
Omg database crash deleted my signature, as a side effect this immensely improved wc3c.
cohadar is offline   Reply With Quote
Old 11-29-2007, 03:25 PM   #24
Rising_Dusk
Obscurity, the Art


Projects Director
Project Leader: OD
 
Join Date: Feb 2006
Posts: 9,729

Submissions (27)

Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)Rising_Dusk has a reputation beyond repute (1192)

Hero Contest #3 - 1st PlaceApproved Map: Desert of ExileApproved Map: Advent of the ZenithHero Contest #2 - 1st PlaceHero Contest - Third place>

Send a message via AIM to Rising_Dusk Send a message via MSN to Rising_Dusk
Default

I don't have to read through code and have WC3 on the computers I post on to put up with people like you.
__________________
Rising_Dusk is offline   Reply With Quote
Old 12-07-2007, 09:32 AM   #26
waaaks
User
 
waaaks's Avatar
 
Join Date: Apr 2007
Posts: 356

waaaks is on a distinguished road (12)

Default

cool spell
__________________
waaaks is offline   Reply With Quote
Old 05-26-2014, 03:11 PM   #27
pusha1999
User
 
Join Date: Jan 2014
Posts: 3

pusha1999 has little to show at this moment (0)

Default

hard to read this code...:|, and there is some unfinished things like u create local trigger but not null after finish.
but spell is good.
pusha1999 is offline   Reply With Quote
Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off


All times are GMT. The time now is 01:12 PM.


Affiliates
The Hubb The JASS Vault Clan WEnW Campaign Creations Clan CBS GamesModding Flixreel Videos

Powered by vBulletin (Copyright ©2000 - 2019, Jelsoft Enterprises Ltd).
Hosted by www.OICcam.com
IT Support and Services provided by Executive IT Services