What to change on Wc3

Anachron · 08-19-2009, 10:44 AM

Hello all. Since the new Patch (1.24) has been released, I think its time
to ask for other fixes.

I am collecting a list of signatures to get blizzard to change their code,
here are some suggestions I made:

Camera
1. SetCameraTargetPositionX
2. SetCameraTargetPositionY
3. SetCameraTargetPositionZ
4. SetCameraEyePositionX
5. SetCameraEyePositionY
6. SetCameraEyePositionZ
Arrays
1. Index > 8191
2. 2D Arrays
3. Assoziative Indexing
Items
1. GetItemGoldCost()
Trackables
1. add GetTriggerPlayer()
2. add RemoveTrackable()
3. add MoveTrackable()
Lightning
1. SetLightningX1()
2. SetLightningX2()
3. SetLightningY1()
4. SetLightningY2()
Events
1. TriggerClearEvents()
2. EVENT_PLAYER_UNIT_DAMAGED
3. GetUnitDamage()
Location / Coordinates
1. GetPointZ()
Heroes
1. More then 5 Hero Skills possible
Minimap
1. HideMiniMap()
2. SetMiniMap(PATH)
3. DisableCameraReset()
Information
1. about SetUnitLoc()
2. about the "return-bug"

Other:

Object Editor Functions

Please give other suggestions, and please remember, they have to be REALISTIC!

Gorman · 08-19-2009, 10:55 AM

RemoveMemoryLeaks()

Switch33 · 08-19-2009, 11:11 AM

Quote:

Originally posted by Gorman:
RemoveMemoryLeaks()

Wow pure realism. . .

How bout fix hashtable problems? Since they didn't even get that right.

Also. . . it's sort of funny how some maps suddenly don't work that use GUI since the way it was coded was changed.(On blizzard noticing this happened. They will be probably more reluctant to change stuff too much as it may change coding and break mapz like they already did. )

Anachron · 08-19-2009, 11:41 AM

Memory leaks can not be cleaned, since you don't know if you need the data or not.

Its good that I didn't use Hashtables, I knew blizzard would create bugs there aswell.

Toadcop · 08-19-2009, 11:41 AM

afaik today 1.24b will be released O_O so...

0zyx0 · 08-19-2009, 11:45 AM

SetLightningX1(), SetLightningX2(), SetLightningY1(), etc...
GetItemGoldCost()
TriggerClearEvents()
GetUnitDamage()
EVENT_PLAYER_UNIT_DAMAGED

And most important:
GetPointZ(x, y)

Anachron · 08-19-2009, 11:45 AM

They surely will NOT fix the Trackables, also there are many other things mappers want.

Edit: That was for Toadcops post.

I updated the list.

Pyrogasm · 08-19-2009, 11:50 AM

Quote:

Originally Posted by 0zyx0

SetLightningX1(), SetLightningX2(), SetLightningY1()

JASS:

native MoveLightning                takes lightning whichBolt, boolean checkVisibility, real x1, real y1, real x2, real y2 returns boolean
native MoveLightningEx              takes lightning whichBolt, boolean checkVisibility, real x1, real y1, real z1, real x2, real y2, real z2 returns boolean

What's wrong with those?

Anachron · 08-19-2009, 11:52 AM

Quote:

Originally Posted by Pyrogasm

JASS:

native MoveLightning                takes lightning whichBolt, boolean checkVisibility, real x1, real y1, real x2, real y2 returns boolean
native MoveLightningEx              takes lightning whichBolt, boolean checkVisibility, real x1, real y1, real z1, real x2, real y2, real z2 returns boolean

What's wrong with those?

They call to much actions.
(Its the same why you don't use BJs at all, aslong as they are bad)

Pyrogasm · 08-19-2009, 11:53 AM

...

That's retarded. Why don't we want a MoveLocationX() or MoveLocationY(), then? Why not break up every function so that we can have every permutation of the possible arguments just for the sake of some arbitrary 'faster'?

Hell, I've never even heard of anyone complaining about MoveLightningEx() being too slow.

Ever.

0zyx0 · 08-19-2009, 11:59 AM

The problem with MoveLightningEx() is that you have to know the old position of the lightning when only one coordinate has to change. Same problem with SetLightningColor().

Earth-Fury · 08-19-2009, 12:02 PM

Quote:

Originally Posted by 0zyx0

The problem with MoveLightningEx() is that you have to know the old position of the lightning when only one coordinate has to change. Same problem with SetLightningColor().

That would be better solved with:

MoveLightningSource(lit,x,y,z)
MoveLightningDest(lit,x,y,z)

than a function per component...

Anachron · 08-19-2009, 01:23 PM

Quote:

Originally Posted by Pyrogasm

...

That's retarded. Why don't we want a MoveLocationX() or MoveLocationY(), then? Why not break up every function so that we can have every permutation of the possible arguments just for the sake of some arbitrary 'faster'?

Hell, I've never even heard of anyone complaining about MoveLightningEx() being too slow.

Ever.

Hmm, but whats so bad about having one native to change some handle value?

Gorman · 08-19-2009, 01:48 PM

Quote:

Originally Posted by Anachron

Memory leaks can not be cleaned, since you don't know if you need the data or not.

It uses magic.

Anachron · 08-19-2009, 01:51 PM

Really, be serious. I mean I wish that too, but it could never be possible.
So, any serious things you want to have?

08-19-2009, 10:44 AM	#1
Anachron User Join Date: Mar 2009 Posts: 1,079	What to change on Wc3 Hello all. Since the new Patch (1.24) has been released, I think its time to ask for other fixes. I am collecting a list of signatures to get blizzard to change their code, here are some suggestions I made: Camera SetCameraTargetPositionX SetCameraTargetPositionY SetCameraTargetPositionZ SetCameraEyePositionX SetCameraEyePositionY SetCameraEyePositionZ Arrays Index > 8191 2D Arrays Assoziative Indexing Items GetItemGoldCost() Trackables add GetTriggerPlayer() add RemoveTrackable() add MoveTrackable() Lightning SetLightningX1() SetLightningX2() SetLightningY1() SetLightningY2() Events TriggerClearEvents() EVENT_PLAYER_UNIT_DAMAGED GetUnitDamage() Location / Coordinates GetPointZ() Heroes More then 5 Hero Skills possible Minimap HideMiniMap() SetMiniMap(PATH) DisableCameraReset() Information about SetUnitLoc() about the "return-bug" Other: Object Editor Functions Please give other suggestions, and please remember, they have to be REALISTIC! __________________ CustomInventory [Discussion - Download] - Got Directors Cut! CustomMissle [Discussion - [Download (not yet)] - In development! Other systems [Spawn System] [Move System] [CustomBar] [SpellBar] Last edited by Anachron : 08-24-2009 at 04:13 PM.

08-19-2009, 11:41 AM	#4
Anachron User Join Date: Mar 2009 Posts: 1,079	Memory leaks can not be cleaned, since you don't know if you need the data or not. Its good that I didn't use Hashtables, I knew blizzard would create bugs there aswell. __________________ CustomInventory [Discussion - Download] - Got Directors Cut! CustomMissle [Discussion - [Download (not yet)] - In development! Other systems [Spawn System] [Move System] [CustomBar] [SpellBar]

08-19-2009, 11:41 AM	#5
Toadcop BuranX Join Date: Jul 2006 Posts: 1,886 Submissions (4)	afaik today 1.24b will be released O_O so... __________________ DJ Eremit - Tanz De Seele (YOMC Club mix)

08-19-2009, 11:45 AM	#6
0zyx0 Perfectionist noob Join Date: Mar 2009 Posts: 255	SetLightningX1(), SetLightningX2(), SetLightningY1(), etc... GetItemGoldCost() TriggerClearEvents() GetUnitDamage() EVENT_PLAYER_UNIT_DAMAGED And most important: GetPointZ(x, y) __________________ My new signature - Now easier to understand than ever!

08-19-2009, 11:45 AM	#7
Anachron User Join Date: Mar 2009 Posts: 1,079	They surely will NOT fix the Trackables, also there are many other things mappers want. Edit: That was for Toadcops post. I updated the list. __________________ CustomInventory [Discussion - Download] - Got Directors Cut! CustomMissle [Discussion - [Download (not yet)] - In development! Other systems [Spawn System] [Move System] [CustomBar] [SpellBar] Last edited by Anachron : 08-19-2009 at 11:48 AM.

08-19-2009, 11:59 AM	#11
0zyx0 Perfectionist noob Join Date: Mar 2009 Posts: 255	The problem with MoveLightningEx() is that you have to know the old position of the lightning when only one coordinate has to change. Same problem with SetLightningColor(). __________________ My new signature - Now easier to understand than ever!

08-19-2009, 01:51 PM	#15
Anachron User Join Date: Mar 2009 Posts: 1,079	Really, be serious. I mean I wish that too, but it could never be possible. So, any serious things you want to have? __________________ CustomInventory [Discussion - Download] - Got Directors Cut! CustomMissle [Discussion - [Download (not yet)] - In development! Other systems [Spawn System] [Move System] [CustomBar] [SpellBar]

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search