![]() |
#16 | |
retired coder | real ilfe
|
![]() Quote:
Please enjoy and give opinion. |
|
![]() |
![]() |
Sponsored Links - Login to hide this ad! |
|
![]() |
#17 |
100% Genuine Retard!
|
![]() Yo Flame_Phoenix don't get offended please, here are my comments; The spell looks typical, A nova spell that works like holy light, Nova-like spells are common nowadays so it doesn't give you a " Yay cool! XD " feeling when you cast it. Now about your code, it looks very organized, lovely indeed. Also, handles stored on locals need only be nulled if they are dynamic.
__________________Good Luck creating more spells dude, you've improved so much now. |
![]() |
![]() |
![]() |
#18 | ||||
retired coder | real ilfe
|
![]() Quote:
Anyway, most spells are outdated and use Kattanas Handle Vars, so I guess this one can be used (and the main reason why I am submitting it) to do more stuff than just a Light Nova =) Quote:
Quote:
Quote:
Anyway thx for your opinion, positive feedback is always appreciated. PS: when will some one mod this spell again ? Last edited by Flame_Phoenix : 09-29-2008 at 06:51 PM. |
||||
![]() |
![]() |
![]() |
#19 | |
100% Genuine Retard!
|
![]() Quote:
EDIT: just to clear things up, try running these scripts: ![]() scope Test initializer Init private function Display takes nothing returns nothing local trigger t=CreateTrigger() call BJDebugMsg(I2S(H2I(t))) call DestroyTrigger(t) endfunction private function Init takes nothing returns nothing local trigger trig=CreateTrigger() call TriggerRegisterPlayerEvent(trig, Player(0), EVENT_PLAYER_END_CINEMATIC) call TriggerAddAction(trig, function Display) endfunction endscope ![]() scope Test initializer Init globals private constant trigger Trig=CreateTrigger() endglobals private function Display takes nothing returns nothing local trigger t=Trig call BJDebugMsg(I2S(H2I(t))) endfunction private function Init takes nothing returns nothing local trigger trig=CreateTrigger() call TriggerRegisterPlayerEvent(trig, Player(0), EVENT_PLAYER_END_CINEMATIC) call TriggerAddAction(trig, function Display) endfunction endscope The first example will leak a reference id because it was not nulled and also because a new handle is being referenced each time it is ran. The second on the other hand will always return a constant id since it also refers to a constant handle regardless of the local variable being used to reference it. In short, handles that will be used throughout the game are safe to be referenced with local variables without nulling it after using it inside functions. Last edited by chobibo : 09-29-2008 at 08:04 PM. |
|
![]() |
![]() |
![]() |
#20 |
retired coder | real ilfe
|
![]() AHh thx for your enthusiasm in my work =)
__________________+rep for being a nice guy! |
![]() |
![]() |
![]() |
#21 |
Procrastination Incarnate
Development Director
|
![]() An interesting option to add would be a boolean that allows the spell directions to adapt to the caster's facing, that would be particularly useful for versions of the spell with few long rays, like 4.
__________________Anyway, the spell looks nice, approved. |
![]() |
![]() |
![]() |
#22 |
retired coder | real ilfe
|
![]() This is in deed interesting, except for the fact I have no idea on how to do it lol...
__________________I will try updating this as you requested, more news soon. Anyway, thx fro approval =) EDIT EDIT EDIT Ok guys, this spell was updated to Version 1.5 !! Now Anitarfs suggestion was added ! I am sure you will like the new changed, and I hope you all use this spell. =D Credits if use please =P Last edited by Flame_Phoenix : 11-10-2008 at 10:35 PM. |
![]() |
![]() |
![]() |
#23 |
retired coder | real ilfe
|
![]() Updated for patch 1.24. Only changed updated TimerUtils.
__________________ |
![]() |
![]() |
![]() |
#24 |
User
|
![]() the map appears to be corrupted.
|
![]() |
![]() |
![]() |
Thread Tools | Search this Thread |
|
|