TimedLoop

[akolyt0r]

Originally Posted by Flame_Phoenix

I read the documentation before posting on this thread Anitarf, you taught me that the hard way ...


This does not solve my problem ...
Assume for instance my user is an idiot, or a newb bigger than me, and that he makes:

JASS:

set TimedLoop_PERIOD = 10 //in seconds...

So, when my hero dies I set a boolean to false and ... 10 SECONDS later the spells dies ...
Correct me if I am wrong, but this is horrible =S
My question is: "Is there a way to make this work without having to wait TimedLoop_PERIOD seconds?"
If no, can it be added?

You can do your cleanup stuff directly in your death-trigger or whatever ...
but you have to make sure that the ontimeloop method wont fuck up afterwards.
So the only thing you have to do is, you add some private boolean heroDead=false, set this one to true in your death-trigger, and check in the ontimeloop method if heroDead==true ...so you know that the hero is already dead, and most of the spell stuff is already cleaned up ... well except the struct itself... so return TimedLoop_STOP now ...

depending on your implementation, and this system (didnt look that deep into it ..), maybe even a simple call X.destroy() would be sufficient, dunno.

[Flame_Phoenix]

So you are saying I should ... do something like this?

JASS:

//struct with stuff

boolean stopNow = false
private method onTimedLoop takes nothing returns boolean
        //instance's timer expired:
        
        if (stopNow) then
            return TimedLoop_STOP
        endif

     return TimedLoop_CONTINUE

     //do my other stuff!
endmethod

//endstruct
private function Actions takes nothing returns nothing
    local unit vic = GetTriggerUnit()
    //get the struct related to this unit
    set stopNow = true
    vicStruct.onTimedLoop()
endfunction

private function Init takes nothing returns nothing
    local trigger BurningBloodTrg = CreateTrigger(  )
        call TriggerRegisterAnyUnitEventBJ( BurningBloodTrg, EVENT_PLAYER_UNIT_DEATH )
        call TriggerAddAction( BurningBloodTrg, function Actions )
endfunction

And sorry for the indentation =P

[Flame_Phoenix]

Ako if your solution is what I implemented then it will not work because onTimedLoop is private ... meaning I can't call it from a function outside everything ...

Is there a good solution for the problem I presented earlier ??
I would appreciate if someone could say one =S

[akolyt0r]

i meant that boolean as struct member ... didnt make that clear though 0.o

and of course you should NOT NOT NOT call onTimedLoop manually !!!

[Flame_Phoenix]

i meant that boolean as struct member ... didnt make that clear though 0.o

Ya ...I already do that ... (realized my example was in bad shape and fixed it)

and of course you should NOT NOT NOT call onTimedLoop manually !!!

Meh xD

So, I am really forced to wait those 10 seconds?

[akolyt0r]

Originally Posted by Flame_Phoenix

Ya ...I already do that ... (realized my example was in bad shape and fixed it)


Meh xD

So, I am really forced to wait those 10 seconds?

NO... you really need me to do this ? -.-

JASS:

scope foobar

struct mySpell
    static mySpell array SPELLZ
    private boolean heroDead=false
        private unit caster
    static method create takes unit castu returns mySpell
        local mySpell this = mySpell.allocate()
        set .caster = castu
        set SPELLZ[GetUnitId(caster)]=this //= attach struct to unit
        return this
    endmethod
    method heroDied takes unit u returns nothing
        if not heroDead and u==caster then //still the same unit ?, did the unit already die before ?
            set heroDead=true
            //cleanup stuff
        endif
    endmethod
    private method onDestroy takes nothing returns nothing
        if not heroDead then
            //cleanup
        else
            //hero = dead, so we know that most of the stuff
            //already is cleaned up ..so we dont have to do this anymore
        endif
    endmethod
    private method onTimedLoop takes nothing returns boolean
        //instance's timer expired:
        if (.heroDead) then
            //just exit
            return TimedLoop_STOP
        endif
        //do my other stuff!		
        return TimedLoop_CONTINUE
    endmethod
endstruct

private function Actions takes nothing returns nothing
    local unit vic = GetTriggerUnit()
    local mySpell this = mySpell.SPELLZ[GetUnitId(vic)] //get attached struct
    if this>0 then //struct seems valid
        call this.heroDied(vic)
    endif
endfunction

private function Init takes nothing returns nothing
    local trigger BurningBloodTrg = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( BurningBloodTrg, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( BurningBloodTrg, function Actions )
endfunction
endscope

i dont guarantee this is working code, i dont have any wc3 at hand at the moment.

[Flame_Phoenix]

Weermmmm Ako, in that example you will wait 10 seconds ... unless you call .destroy() in method .heroDied, but I think that will mess up things badly and so it is not advisable.
All this time, your solution is my problem xD

[akolyt0r]

Originally Posted by Flame_Phoenix

Weermmmm Ako, in that example you will wait 10 seconds ... unless you call .destroy() in method .heroDied, but I think that will mess up things badly and so it is not advisable.
All this time, your solution is my problem xD

NO, because you do your "cleanup stuff" in the heroDied method ...
please ...open your eyes .. lol
Of course you could make another private method called cleanup or something, which you call in onDestroy and heroDied (where "//cleanup (stuff)" currently is located) if you want to avoid double cleanup code ..

[Flame_Phoenix]

Wermmm Ok, I guess my big problem here is .. what am I supposed to do on the CleanUp section?
I can't call onDestroy (which would be the ideal) so what's the point?

(As you may have already noticed, I am having trouble on this xD)

[akolyt0r]

Originally Posted by Flame_Phoenix

Wermmm Ok, I guess my big problem here is .. what am I supposed to do on the CleanUp section?
I can't call onDestroy (which would be the ideal) so what's the point?

(As you may have already noticed, I am having trouble on this xD)

post your spell in the Trigger&Scripts forum, maybe we can help you there ...
we should stop to spam Vex's thread ...

[Anitarf]

Originally Posted by Flame_Phoenix

Ako, in that example you will wait 10 seconds ...

No, he won't, only idiots will wait 10 seconds, and Vex already explained more than ten posts ago what he thinks of them, so why do you keep bringing these 10 seconds up? Seriously. That's like saying "any spell that uses TimedLoop will bug if the user sets the TimedLoop_PERIOD to a value larger than the spell's duration." No shit, Captain Obvious! Guess what? Even if you coded the looping yourself instead of using TimedLoop, users could still break it with moronic inputs. Just let it go, nobody cares about this "problem".

[Flame_Phoenix]

Just let it go, nobody cares about this "problem".

Fine, I will make sure you remember these words once you start seeing my codes using this procedure.

post your spell in the Trigger&Scripts forum, maybe we can help you there ...
we should stop to spam Vex's thread ...

I guess there is no need for that now ... thx anyway.

[SanKakU]

i like your simple scripts. this one and itemdex are both seeming to work out nicely.