The Spell Request Thread (Now with vJASS!)

[Zerzax]

No prob.

[wedged_mind]

Righto, will see what I useful applications this system might have but the chance of me understanding it are pretty slim seeing as to how I've no experience with JASS and how you yourself admit that you've yet to totally understand it. No clue as to how you'll tie it in with whatever it is you've got up yer sleeve.

Again, looking forward to what you manage to design and thank you muchly

[Zerzax]

This might be demanding, but I think you should find out exactly what ABuff does and see if it fits the description of the system you want. If it is missing certain components and you feel you really do need an independent system, then come to me, because this is a fair amount of work and I'd like to make sure redundant systems aren't being made and that we can minimize the amount of work required.

[wedged_mind]

Copy. Will see what I can figure out.

[Zerzax]

Thanks for doing this, I think it will help.

[Mendel]

Could i request skill?
well this is prety simple, and i belive many have done it since i saw it in maps, altough they weren't perfect,
this skills is the same as fire skull or fire bomb what ever it is named, (From diablo3 ^^ witch doctor, wich can be seen at the gameplay of him,)
well basicliy works like a grenade, u throw a fireball on the ground and it explodes damages aoe,

i have searched the forums befor posting and found this tutrial:
Making a grenade type spell/
this is like exactly what i was searching, but here are the problems with it:
it uses 3 costum abilitys, i belive it's too much and not "clean" XD
uses a vaulnarble dummy, so it happends that the monsters are attacking the air :\.

i hope u could make one for me,
also i would like to add that
monsters wich didn't get killed by that, are set on fire and getting damage over time and slows down by 25%;

the damage is caculated like this:

50+(50*level of ability)+( (int of casting unit)² /7)
this way u don't have to make "if" for each level, or am i wrong?
all other elemnts of the skill such as the dmg overtime and aoe is same for each level.
make it 5 levels for now.

also, when the explosion accures it will be very nice if the screen will shake as if it was an earthquicke
so will it shake for the casting player? or will it shake to all players in a radius of the explosion?
you decide :]

also could i ask it in Gui and jass? since i don't know jass i would like to see how u made it in GUI, but for use i would prefer jass cause of that local varibales.

Thanks :]

[cosmicat]

Originally Posted by Mendel

Making a grenade type spell/
this is like exactly what i was searching, but here are the problems with it:
it uses 3 costum abilitys, i belive it's too much and not "clean" XD
uses a vaulnarble dummy, so it happends that the monsters are attacking the air :\.

The vulnerability of the dummy is easy to fix - just give it the Locust ability like any other dummy. As for "cleanliness," I'd be more worried about the GUI used in the tutorial than the number of custom abilities. Still, your concern is valid - less custom object data is generally preferred for portable spells.

Originally Posted by Mendel

i hope u could make one for me,
also i would like to add that
monsters wich didn't get killed by that, are set on fire and getting damage over time and slows down by 25%;

This would most likely need to be applied with yet another custom ability.

Originally Posted by Mendel

the damage is caculated like this:
50+(50*level of ability)+( (int of casting unit)² /7)
this way u don't have to make "if" for each level, or am i wrong?
all other elemnts of the skill such as the dmg overtime and aoe is same for each level.
make it 5 levels for now.

The formula provided is sufficient to accommodate an infinite number of ability levels.

Originally Posted by Mendel

also, when the explosion accures it will be very nice if the screen will shake as if it was an earthquicke
so will it shake for the casting player? or will it shake to all players in a radius of the explosion?
you decide :]

If I end up doing this, I'll probably leave it up to you, with the casting player as a default. I am of the opinion that camera effects are generally cheesy in real-time multiplayer games, though.

Originally Posted by Mendel

also could i ask it in Gui and jass? since i don't know jass i would like to see how u made it in GUI, but for use i would prefer jass cause of that local varibales.

I take this to mean that you want the functions used by the spell to be in "vanilla" JASS, and an example implementation in GUI. Is this correct?

I have classes for the next five hours. Seriously. So I won't be able to work on this at all until later today. Also, I have an exam tomorrow and a bit of homework to take care of, so I can't promise anything. However, the ability you describe sounds simple enough, and since I need to get to work on a certain...project...before everyone (including myself) forgets about it entirely, I probably need to do something like this to practice handicapped coding.

EDIT:
As I'm working on this, I'm finding quite a few implementation options that could work in different ways.

Are you comfortable with setting up constant functions in Jass? (If not, I'll use GUI udg_s, but it'll probably clutter up your variable list.)

How should the damage over time / slow effect be applied? (Jass timers, disabled spellbooks, and Hashtable vs dummy cast ability)

How should the projectile effect be generated? (Yet another custom ability would again be the cleanest objectively, but you seem to have your own opinions)

[Zerzax]

I have a base AoE damage modeled off the spell, Mendel, if you'd like to see it. It doesn't do damage over time and doesn't shake around but that can be implemented pretty easily.

[Kam]

If you are still working here, I need the following spell:

A buildable "waygate" where the owner can build a maximum of two of these structures, and once the second is built they are connected until one is destroyed. The units should not have a teleportation affect, instead when they run into the structure they sink down into it. It would also be nice if the duration of the move was based on the distance between the two structures.

[Bustaboom]

Spell Name: No Escape
4 levels
A javelin will be trown at the target unit stabbing into his chest and (causing damage based on level of spell), and a ward or spike or some kind will stick into the ground next to him and a rope (arial shackle lightning effect) will be connecting the 2. The spike will be stationary but the rope will act as a elastic rubber band thing and will pull at the unit as he tries to move further away; at a certain distanct (600) the unit will be dragged back to within 100 of the spike. It can be broken based off of the strength of the unit or the number of tries that the unit makes to get away. When the unit breaks the rope it will be slowed for 3 seconds.

Tooltip: dont care you can make it up
GUI or JASS: I prefer GUI but whatever you feel like
One unit will able to use this per map.
Special effect or icon: Ground dirt kickup special effect forget what its called sorry

[Zerzax]

I'm helping Bustaboom out with his spell.

[Pyrogasm]

I won't close this thread, but merely repeat the disclaimer I now put at the top of the first post.

Disclaimer: I'm no longer an active member of this site, and as such I cannot maintain this thread any more. All spells and code snippets posted by me in this thread are public resource, and may be used by anyone for any reason as long as appropriate credit is given.

-Pyrogasm (October 23, 2009)

[Zerzax]

:(, I hope we see you around at SC2C, Pyro. I can't really take the responsibility of an entire thread but I can help out occasionally with requests, as I am now doing with Bustaboom. If anyone else wants to help out with requests, by all means say so and contribute - I think it's an honorable and fun pursuit to keep up for the site.

[Zerzax]

Rawr! I have completed Bustaboom's request. I'm afraid no more requests will come for a while, as I'm working on the Hero Contest immediately tomorrow. But heck, no one can say the thread is dead yet...

No Escape

Hurls a vicious javelin at a target, dealing initial damage and chaining the victim to a magical ward. The chain drags targets back when they step out of range. If the target is a hero, the number of drags before the chain breaks and damages depends on the caster's agility and target's strength. Non-hero units are dragged back four times before the chain breaks.

3 levels

v1.1 script:

// No Escape v1.1
// Coded by Zerzax, requested by Bustaboom on Pyrogasm's Spell Request thread on Wc3c.
// Uses vJASS and 3 libraries:
//      UnitIndexingUtils
//      SimError
//      and BoundSentinel
// Thanks to Vexorian and Rising_Dusk for making these systems available at Wc3c. 
// Not commented at the moment, I'll see if I have time....

scope NoEscape

    globals
        private constant integer SPELL_ID = 'A000'
        private constant integer DUMMY_ID = 'e000'
        private constant integer JAVELIN_MODEL_ID = 'A001'
        private constant integer WARD_MODEL_ID = 'A002'
        private constant integer SLOW_ID = 'A003'
        
        private constant integer MAX_TRIES = 4
        
        private constant effecttype ROPE_EFFECT = EFFECT_TYPE_LIGHTNING
        private constant effecttype PIERCE_EFFECT = EFFECT_TYPE_SPECIAL
        private constant effecttype BREAK_EFFECT = EFFECT_TYPE_MISSILE
        private constant effecttype GROUND_IMPACT_EFFECT = EFFECT_TYPE_AREA_EFFECT
        
        private constant real TIMER_INTERVAL = 0.025
        
        private constant real JAVELIN_VELOCITY = 800.00
        private constant real PIERCE_RANGE = 25.00
        private constant real RANGE_PULLBACK = 100.00
        private constant real RANGE_MAX = 600.00
        private constant real DRAG_BACK_SPEED = 1000.00
        private constant real INITIAL_THROW_HEIGHT = 60.00
        private constant real FINAL_THROW_HEIGHT = 60.00
        private constant real ARC_VELOCITY = 300.00
        private constant real ARC_HEIGHT = 275.00
        private constant real ARC_DISTANCE = 200.00
        private constant real THRESHOLD_DISTANCE = 1500.00
        
        private constant string ATTACH_POINT = "chest"
        private constant string SLOW_ORDER = "slow"
        private constant string DUST = "war3mapImported\\KnockBackDust.mdx"
    
    endglobals
    
    
    private constant function PierceDamage takes integer level returns real
        return 50.00 + 50.00 * level
    endfunction
    
    private constant function BreakBaseDamage takes integer level returns real
        return 75.00 * level
    endfunction
    
    private constant function BreakDamageFactor takes integer tries returns real
        return 1./tries
    endfunction
    
    private constant function TryConversion takes integer agi, integer str returns real
        return 1.5*agi/str
    endfunction
    
    private constant function TarCondition takes unit tar returns boolean
        return IsUnitType(tar, UNIT_TYPE_HERO)
    endfunction 
    
    struct javelin
        static timer periodic
        static javelin array active
        
        static integer actIndex = 0
        static javelin array current
        static unit slower = null
        
        integer phase = 1
        integer level = 0
        integer tries = 0
        integer maxTries = 0 
    
        unit caster = null
        unit target = null
        unit jav = null
        effect dust = null
        
        real jx = 0
        real jy = 0
        real cos = 0.0
        real sin = 0.0
        real d = 0.0
        
        real z = 0.0
        real t = 0.0
        
        lightning joiner = null
        boolean dragBack = false
        
        method aim takes nothing returns nothing
            local unit tar = .target
            local unit j = .jav
            local real tx = GetUnitX(tar)
            local real ty = GetUnitY(tar)
            local real a = Atan2(ty-.jy,tx-.jx)
            
            set .cos = Cos(a)
            set .sin = Sin(a)
            set .jx = .jx + JAVELIN_VELOCITY*.cos*TIMER_INTERVAL
            set .jy = .jy + JAVELIN_VELOCITY*.sin*TIMER_INTERVAL
            
            call SetUnitX(j,.jx)
            call SetUnitY(j,.jy)
            call SetUnitFacing(j,180/bj_PI*a)
            
            if IsUnitInRange(j, tar, PIERCE_RANGE) then
                call UnitDamageTarget(j, tar, PierceDamage(.level), true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS)
                call DestroyEffect(AddSpellEffectTargetById(SPELL_ID, PIERCE_EFFECT, tar, ATTACH_POINT)) 
                set .phase = .phase + 1
            endif

            set j = null
            set tar = null
        endmethod
        
        method arc takes nothing returns nothing
            local unit jav = .jav
            local real h = GetUnitFlyHeight(jav)
            local real t = .t + TIMER_INTERVAL/(ARC_DISTANCE/ARC_VELOCITY)
            
            set .t = t
            call SetUnitFlyHeight(jav, t*t*.001 + 2*t*(1-t)*ARC_HEIGHT + (1-t)*(1-t)*FINAL_THROW_HEIGHT, 0.0)
            call SetUnitAnimationByIndex(jav, R2I(Atan2(GetUnitFlyHeight(jav)-h,ARC_VELOCITY*TIMER_INTERVAL)*bj_RADTODEG+90.5))
        
            set .jx = .jx + ARC_VELOCITY*.cos*TIMER_INTERVAL
            set .jy = .jy + ARC_VELOCITY*.sin*TIMER_INTERVAL
            call SetUnitX(jav, .jx)
            call SetUnitY(jav, .jy)
            set .d = .d + ARC_VELOCITY*TIMER_INTERVAL
            
            if .d >= ARC_DISTANCE then
                call UnitRemoveAbility(jav, JAVELIN_MODEL_ID)
                call UnitAddAbility(jav, WARD_MODEL_ID)
                call DestroyEffect(AddSpellEffectById(SPELL_ID, GROUND_IMPACT_EFFECT, .jx, .jy))
                call SetUnitAnimationByIndex(jav, 91)
                set .joiner = AddLightningEx(GetAbilityEffectById(SPELL_ID, ROPE_EFFECT, 0), false, .jx, .jy, FINAL_THROW_HEIGHT, GetUnitX(.target), GetUnitY(.target), FINAL_THROW_HEIGHT)
                set .phase = 3
            endif
            
            set jav = null
        endmethod
        
        method drag takes nothing returns boolean
            local unit t = .target
            local real x = 0
            local real y = 0
            local real a = 0
            
            if .dragBack then
                set x = GetUnitX(t)
                set y = GetUnitY(t)
                set a = Atan2(.jy-y,.jx-x)
                call SetUnitX(t, x + DRAG_BACK_SPEED*Cos(a)*TIMER_INTERVAL)
                call SetUnitY(t, y + DRAG_BACK_SPEED*Sin(a)*TIMER_INTERVAL)
                if IsUnitInRange(t, .jav, RANGE_PULLBACK) then
                    set .dragBack = false
                    call DestroyEffect(.dust)
                endif
            else
                if not IsUnitInRange(t, .jav, RANGE_MAX) then
                    set .tries = .tries + 1
                    set .dragBack = true
                    set .dust = AddSpecialEffectTarget(DUST, t, "origin")
                    if .tries >= .maxTries then
                        call DestroyEffect(.dust)
                        call UnitDamageTarget(.caster, t, BreakBaseDamage(.level)*BreakDamageFactor(.tries), true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS) 
                        call DestroyEffect(AddSpellEffectTargetById(SPELL_ID, BREAK_EFFECT, t, ATTACH_POINT))
                        call SetUnitAbilityLevel(.slower, SLOW_ID, .level)
                        call SetUnitX(.slower, GetUnitX(t))
                        call SetUnitY(.slower, GetUnitY(t))
                        call IssueTargetOrder(.slower, SLOW_ORDER, t)
                    endif
                endif
            endif
            call MoveLightningEx(.joiner, true, .jx, .jy, FINAL_THROW_HEIGHT, GetUnitX(t), GetUnitY(t), FINAL_THROW_HEIGHT)
            
            set t = null
            return .tries >= .maxTries
        endmethod

        method action takes nothing returns boolean
            if GetWidgetLife(.target) > 0.405 and IsUnitInRange(.jav, .target, THRESHOLD_DISTANCE) then
                if .phase == 1 then
                    call .aim()
                    return false
                elseif .phase == 2 then
                    call .arc()
                    return false
                elseif .phase == 3 then
                    return .drag()
                endif
            else
                return true
            endif
            return false
        endmethod
        
        static method update takes nothing returns nothing
            local javelin this = 0
            local integer i = 0
            
            loop
                exitwhen i >= .actIndex
                set this = .active[i]
                if .action() then
                    set .actIndex = .actIndex - 1
                    set .active[i] = .active[.actIndex]
                    call .destroy()
                else
                    set i = i + 1
                endif
            endloop
                
            if .actIndex == 0 then
                call PauseTimer(.periodic)
            endif
        
        endmethod
        
        static method create takes unit c, unit t returns javelin
            local javelin this = javelin.allocate()
            
            set .caster = c
            set .target = t
            set .level = GetUnitAbilityLevel(c, SPELL_ID)
            set .current[GetUnitId(t)] = this
            set .jx = GetUnitX(c)
            set .jy = GetUnitY(c)
            
            set .jav = CreateUnit(GetOwningPlayer(c), DUMMY_ID, .jx, .jy, Atan2(GetUnitY(t)-.jy, GetUnitX(t)-.jx)*180.00/bj_PI) 
            call UnitAddAbility(.jav, JAVELIN_MODEL_ID)
            call UnitAddAbility(.jav, 'Amrf')
            call UnitRemoveAbility(.jav, 'Amrf')
            call SetUnitFlyHeight(.jav, INITIAL_THROW_HEIGHT, 0.0)
            
            if IsUnitType(t, UNIT_TYPE_HERO) then
                set .maxTries = R2I(MAX_TRIES*TryConversion(GetHeroAgi(c,true),GetHeroStr(t,true)))
            else
                set .maxTries = MAX_TRIES
            endif
            
            if .actIndex == 0 then
                call TimerStart(.periodic, TIMER_INTERVAL, true, function javelin.update)
            endif
            set .active[.actIndex] = this
            set .actIndex = .actIndex + 1
            
            return this
        endmethod
    
        method onDestroy takes nothing returns nothing
            if .joiner != null then
                call DestroyLightning(.joiner)
                set .joiner = null
            endif
            call UnitRemoveAbility(.jav, JAVELIN_MODEL_ID)
            call UnitRemoveAbility(.jav, WARD_MODEL_ID)
            call KillUnit(.jav)
            set .current[GetUnitId(.target)] = 0
        endmethod
        
        static method spellExecute takes nothing returns boolean
            if GetSpellAbilityId() == SPELL_ID then
                call javelin.create(GetTriggerUnit(), GetSpellTargetUnit())
            endif
            return false
        endmethod
        
        static method castCheck takes nothing returns boolean
            if GetSpellAbilityId() == SPELL_ID and .current[GetUnitId(GetSpellTargetUnit())] != 0 then
                call PauseUnit(GetTriggerUnit(), true)
                call IssueImmediateOrder(GetTriggerUnit(), "stop")
                call PauseUnit(GetTriggerUnit(), false)
                call SimError(GetOwningPlayer(GetTriggerUnit()), "Target is already trapped")
            endif
            
            return false
        endmethod
    
        static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
            call TriggerAddCondition(t, Condition(function javelin.spellExecute))
            
            set t = CreateTrigger()
            call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_CAST)
            call TriggerAddCondition(t, Condition(function javelin.castCheck))
            
            set .slower = CreateUnit(Player(15), DUMMY_ID, 0,0,0)
            call UnitAddAbility(.slower, SLOW_ID)
            call UnitRemoveAbility(.slower, 'Amov')
            call SetUnitTurnSpeed(.slower, .10)
            
            set .periodic = CreateTimer()
        
        endmethod
    
    
    endstruct

endscope

EDIT: Crap, forgot about the slow. Will change this soon.
EDIT2: Now included and working. Enjoy!
EDIT3: Fixed a possible bug when heroes were hit. Also added an imported dust effect (from KnockBack system) that Bustaboom requested.

[Bustaboom]

thanks much for the spell it looks great man everything i expected and more great job