Thread: Thunder Whirl
View Single Post
Old 09-04-2007, 02:34 AM   #9
moyack
Evil Emoticon
 
moyack's Avatar


Respected User
Project Leader: PoC
 
Join Date: Jan 2006
Posts: 3,279

Submissions (17)

moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)moyack is a splendid one to behold (666)

AI Tournament #2 - 2nd PlaceHero Contest - Second place

Send a message via MSN to moyack
Default

Other comments:
  • Man!! you have a bunch of constant values... that's not a problem, but it would be a good idea to make some classification with comment lines, so people can find easily where to modify the data. I suggest classify in sound section, constants used by cast struct and knockback struct.

  • It's not very versatile to have predefined the order ID, it would be better to avoid that private constant and directly get the order with GetUnitCurrentOrder(caster).

  • In the InitTrig function, you make an ExecuteFunc("ThunderWhirl_preload"). Why not just do call ThunderWhirl_preload()??
moyack is offline   Reply With Quote