Thread: Timed Effects
View Single Post
Old 01-28-2009, 02:29 PM   #15
Anitarf
Procrastination Incarnate


Development Director
 
Join Date: Feb 2004
Posts: 8,190

Submissions (19)

Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)Anitarf has a brilliant future (903)

2008 Spell olympics - Fire - SilverApproved Map: Old School Alliance TacticsHero Contest #2 - 3rd PlaceSpell making session 2 winner

Default

In the post, you say the function is called StartEffect yet in the script it's called TimedEffect. I don't think either is very suitable, though. The function AddTimedEffect sounds good because it's style follows the related Blizzard's function, AddSpecialEffect (perhaps even better would be AddSpecialEffectTimed). The TimedEffect function should be similar to it's native counterpart, DestroyEffect, hence why I think the most suitable name is something like DestroyeffectTimed.

Also, you should include some short documentation on the use of the library in the library itself, not just the post, since users might get your library from maps that use it rather than from here.
__________________
Anitarf is offline   Reply With Quote