Wc3C.net

Wc3C.net (http://www.wc3c.net/forums.php)
-   vJass Spells (http://www.wc3c.net/forumdisplay.php?f=647)
-   -   Overgrowth (http://www.wc3c.net/showthread.php?t=104647)

FriendlyPsycho 02-23-2009 04:27 AM

I see no reason not to.

erwtenpeller 03-04-2009 12:13 PM

Callahans roots have a fuckload of polygons though... Way, way too many for practical use in warcraft three, especially when used repeatedly.

Viikuna- 03-04-2009 08:11 PM

Using images instead of effects/units is pretty nice also because images cant cover units, which makes it look more clean and clear and everything.

erwtenpeller 03-04-2009 11:11 PM

Everything in the game is a model, basically. If you put an image on a plane, it'd still go through stuff.

What you mean is a splat or ubersplat, a texture superimposed over the terrain texture wich has the same in-game qualities as the terrain texture.

Anitarf 03-15-2009 04:24 PM

I take issue with your use of resources that haven't gone through our approval process yet. I am refering to GroupEnumUnitsInArea and your modification of TimedEffects in particular. TimedEffects is especially problematic because you kept the library name which would break any map that tries to use it along any spells that require the original. That was really the wrong thing to do.

The quickest solution is to inline the code into the spell, both libraries are very short and especially GroupEnumUnitsInArea gets considerably shortened once inlined into a GroupEnum filter.

Also, you create and destroy an xecast object for each spell instance individually, yet you store it in a global variable, making your spell not multi-instanceable. Also, you don't seem to use xecast's recycledelay even though you're using a damage-over-time spell.

Flame_Phoenix 03-28-2009 03:36 PM

1 Attachment(s)
This leaks ....

Please fix it.

Other than that I believe it would be a very nice unbalanced channeling spell =P

Pyrogasm 03-29-2009 12:12 PM

Well that was descriptive, Flame. xD What exactly is leaking?

Flame_Phoenix 03-29-2009 01:04 PM

1 Attachment(s)
Quote:

Well that was descriptive, Flame. xD What exactly is leaking?
I posted the replay; seriously you will only lose a few minutes of your life to find it out....

*sight* Arrghghhhh *sight*

Maybe this image will make it easier for you ...

Attachment 41708

How's that for descriptive now? xD

Anitarf 03-29-2009 03:03 PM

That error message doesn't mean it leaks.

FriendlyPsycho 03-29-2009 04:19 PM

First post being updated. Sorry for the long absence, but this now conforms to what you mentioned Anitarf. Although, I do disagree on the fact that I should exclude the GroupEnumUnitsInArea library and just copy paste it inside the spell scope. That part, I did not do. I figured that people might find it handy, and some people may already have the library in their maps so I'll just be adding worthless lines of code.

EDIT: Updated. Hope all is well now.

Anitarf 03-29-2009 05:07 PM

The point is that GroupEnumUnitsInArea is incredibly inline friendly, it would add a total of 6 lines of code to your spell (a globals block with two reals for coordinates, setting of those reals before a GroupEnum call and a IsUnitInRangeXY call in your enum function) not to mention that it'd be considerably more efficient that way.

Flame_Phoenix 03-29-2009 06:28 PM

Quote:

That error message doesn't mean it leaks.
So double type free is not a leak ?
Even if it is not a leak, it is something that should be fixed (I assume you agree with this statement).

Please fix it.

akolyt0r 03-29-2009 06:38 PM

most of the time the existence of a double free means that there is a leak somewhere aswell, but that is not true all the time ... (depends on the structure of the code.)

Pyrogasm 03-29-2009 11:53 PM

A double free is exactly the opposite of a leak. It's destroying the same object twice.

FriendlyPsycho 03-30-2009 04:26 AM

Updated, removed the use of GroupEnumUnitsInArea. Anything else to fix? I don't know what's causing that double free, but it's nothing map-breakingly huge of an issue.


All times are GMT. The time now is 05:16 AM.

Powered by vBulletin (Copyright ©2000 - 2019, Jelsoft Enterprises Ltd).
Hosted by www.OICcam.com
IT Support and Services provided by Executive IT Services