Wc3C.net (http://www.wc3c.net/forums.php)
-   vJass Spells (http://www.wc3c.net/forumdisplay.php?f=647)
-   -   Demon Huntress Spellpack (http://www.wc3c.net/showthread.php?t=107353)

Anitarf 08-25-2009 12:28 AM

Demon Huntress Spellpack
2 Attachment(s)
This was my and TDR's submission to the third Hero Contest, I figure it's about time I submitted it. The pack consists of four contest abilities and one bonus ability that wasn't included originally because of the four hero skill limit, for their descriptions read the documentation included with their code or download the testmap and try them out.

The spells require the following libraries (not every spell requires all of them):
TimerUtils, Table, SpellEvent, VectorLib, PruneGroup, IsTerrainWalkable, IsUnitSpellResistant, BoundSentinel, xe, ABuff
The abilities in this pack are:
Expand Pounce:
Expand Firestorm:
Expand Soul Glaive:
Expand Elusive steed:
Expand Hunting Grounds:

The custom model for the hero was never finished, so this map includes a WIP version of it for the sake of completeness.

Rising_Dusk 08-25-2009 03:41 PM

I cannot believe I just spent half an hour looking over all that code. From what I can tell, it looks good and I didn't see any critical flaws. Furthermore, you are practically the paragon of portability and using standard libraries, so no worries there. The spells are also quite cool in and of themselves, and big packs make me happy as well. The only thing I dislike is that because I test maps on BNet, I wish people would add computer enemies to maps so that I can. :p

There appears to be a bug with Hunting Grounds and Pounce. It doesn't actually stun for the listed 8s or deal 200 damage, it actually deals only 100 damage and a 4s stun. That should be fixed. You should check the other abilities, too, because I'm convinced none of them were working properly in Hunting Grounds except the evasion when moving (not the movement speed part, there's no way that was 90%) and the Soul Glaive ability.

Anitarf 08-25-2009 10:01 PM

The speed bonus works, but due to the maximum WC3 speed limit it's effect is only noticeable if the unit is also affected by slowing spells. Pounce and Firestorm indeed didn't get the bonus because I completely forgot to set the appropriate struct member in their create methods. The silly mistake has been corrected.

Rising_Dusk 08-25-2009 10:10 PM

Ah yes, I was bouncing into the max MS. Good call. Anyways, after testing, it appears to work happily now and I'd already mentioned previously that the code looks great for all spells.


Anitarf 08-25-2009 10:16 PM

Heh, I just noticed another silly bug with Elusive Steed, it wouldn't work if you learned it while under the effect of Hunting Grounds, fixed that too. The spells should be perfect now! :)

Rising_Dusk 08-25-2009 10:26 PM

Oh, that's a bug I never noticed when testing. Guess that's my fault for auto learning stuff before testing it, hrm.

All times are GMT. The time now is 03:24 PM.

Powered by vBulletin (Copyright ©2000 - 2019, Jelsoft Enterprises Ltd).
Hosted by www.OICcam.com
IT Support and Services provided by Executive IT Services